Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add tests for 'audio_fadeout' FX #1578

Merged
merged 3 commits into from
May 24, 2021
Merged

Add tests for 'audio_fadeout' FX #1578

merged 3 commits into from
May 24, 2021

Conversation

mondeja
Copy link
Collaborator

@mondeja mondeja commented May 24, 2021 •
edited
Loading

  • Refactored audio_fadeout to improve performance.
  • Fix mono clips crashing when audio_fadeout FX applied.
  • Add support to pass duration parameter as time format (AA:BB:CC, tuples...).
  • Add tests (contributes to Add more tests #1355).
  • Document it properly.
  • I have provided code that clearly demonstrates the bug and that only works correctly when applying this fix
  • I have added suitable tests demonstrating a fixed bug or new/changed feature to the test suite in tests/
  • I have properly documented new or changed features in the documentation or in the docstrings
  • I have properly explained unusual or unexpected code in the comments around it

@mondeja mondeja mentioned this pull request May 24, 2021
Open
@coveralls
Copy link

coveralls commented May 24, 2021 •
edited
Loading

Coverage Status

Coverage increased (+0.3%) to 69.198% when pulling de725c0 on mondeja:audio_fadeout-tests into b330dbe on Zulko:master.

@mondeja mondeja added audio Related to AudioClip, or handling of audio in general. enhancement Positive change that does not change the API, i.e. improved performance, using less memory etc. fx Related to advanced effects applied via clip.fx(), or effects in general. bug-fix For PRs and issues solving bugs. tests Related to individual tests in the test suite or running the test suite. and removed enhancement Positive change that does not change the API, i.e. improved performance, using less memory etc. labels May 24, 2021
@mondeja mondeja merged commit 8523616 into Zulko:master May 24, 2021
@mondeja mondeja deleted the audio_fadeout-tests branch May 24, 2021 09:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
audio Related to AudioClip, or handling of audio in general. bug-fix For PRs and issues solving bugs. fx Related to advanced effects applied via clip.fx(), or effects in general. tests Related to individual tests in the test suite or running the test suite.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mondeja @coveralls